-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade rollouts to v0.5.0 #83
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @ezxfv! It looks like this is your first PR to openkruise/kruise-tools 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz fix the comment and some CI error
return err | ||
} | ||
o.DryRunVerifier = resource.NewDryRunVerifier(dynamicClient, discoveryClient) | ||
//discoveryClient, err := f.ToDiscoveryClient() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why modify here?
) | ||
|
||
require ( | ||
github.com/Azure/go-ansiterm v0.0.0-20210617225240-d185dfc1b5a1 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some module may not uesed?
if len(o.Raw) > 0 { | ||
if o.EditBeforeCreate { | ||
return cmdutil.UsageErrorf(cmd, "--raw and --edit are mutually exclusive") | ||
return fmt.Errorf("--raw and --edit are mutually exclusive") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use cmdutil.UsageErrorf
?
@ezxfv Another pr is fixing this problem, so I close this. |
upgrade rollouts to v0.5.0 and support Rollout v1beta1.